Re: [DOC] pg_database_size/pg_tablespace_size error on a missing OID

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: shihao zhong <zhong950419(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [DOC] pg_database_size/pg_tablespace_size error on a missing OID
Date: 2026-09-07 08:43:06
Message-ID: 24B11965-8544-4EAE-8BE9-5C5441F288A1@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Sep 5, 2026, at 21:11, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
>
> Hi hackers,
>
> The introduction to the database object size functions in
> func-admin.sgml says that passing an OID that does not represent an
> existing object returns NULL. That is true for the relation size
> functions, but pg_database_size() and pg_tablespace_size() raise an
> error for a nonexistent OID instead. The attached patch documents the
> exception.
>
> Thanks,
> Shihao
> <0001-doc-note-that-pg_database_size-and-pg_tablespace_siz.patch>

The change overall looks good to me. One nitpick:
```
+ functions, <literal>NULL</literal> is returned, except by
```

“Except by” sounds uncommon, is “expect for” better?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Henri GASC 2026-09-07 08:47:38 Re: [SQL/PGQ] Native executor for Graph query
Previous Message Tatsuya Kawata 2026-09-07 08:40:26 Re: Batching in executor