| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | ji xu <thanksgreed(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Correction to comment of brin_range_deserialize |
| Date: | 2026-01-28 23:13:44 |
| Message-ID: | 24A6C2DC-CB0A-4073-9140-DAEB3C1EBEAE@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jan 28, 2026, at 16:10, ji xu <thanksgreed(at)gmail(dot)com> wrote:
>
> Hi Hackers,
>
> I found an issue in the comments of the src/backend/access/brin/brin_minmax_multi.c file.
>
> The header comment of function brin_range_deserialize currently reads:
> "Serialize the in-memory representation into a compact varlena value."
>
> which looks like a copy/paste error, where "Serialize" should be "Deserialize".
>
> I'm posting this patch to fix the comment.
>
> Regards,
> ji xu
> <v1-0001-Correction-to-comment-of-brin_range_deserialize.patch>
Indeed, like a copy-pasto from the initial commit (ab59610) where the 2 functions (serialize/deserialize) were added.
The updated comment in the patch looks good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2026-01-28 23:16:10 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |
| Previous Message | Chao Li | 2026-01-28 22:59:02 | Re: A few pg_locale.c fixes |