Re: snapshot generation broken again...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: snapshot generation broken again...
Date: 2010-01-06 19:43:52
Message-ID: 24998.1262807032@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc> writes:
> Tom Lane wrote:
>> [ scratches head... ] "make dist" works for me. Can you get a
>> trace indicating what command was used to call genbki.pl?

> heh that's a nice one the snapshot generation script uses "
> gmake -s VERSION=snapshot dist" and that leads to getting "
> --set-version=snapshot" passed to genbki.pl which fails the regex there
> and the if() falls through to the usage().

Huh ... that doesn't make any sense, because the previous shell-script
version also spits up on non-numeric VERSION. How did it work before?

[... thinks ...] Oh: it didn't, because we didn't use to try to call
this during distprep. We'd not want "snapshot" as the version number
in postgres.bki anyway. So we need to change the makefile to not rely
on VERSION for this, I guess. Will fix.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2010-01-06 19:44:13 Re: Auto-extending table partitions?
Previous Message John Naylor 2010-01-06 19:41:07 Re: snapshot generation broken again...