Re: Extensions, patch v20 (bitrot fixes)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PostgreSQL-Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions, patch v20 (bitrot fixes)
Date: 2010-12-19 16:34:13
Message-ID: 24939.1292776453@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> writes:
>> Oh, I wasn't aware that Itagaki-san had objected to Tom's proposal.

> I agree that "the default encoding is UTF-8", but it should be
> configurable by the 'encoding' parameter in control files.

Why is it necessary to have such a parameter at all? AFAICS it just
adds complexity for little if any gain. Most extension files will
probably be pure ASCII anyway. Dictionary files are *far* more likely
to contain non-ASCII characters. If we've gotten along fine with
requiring dictionary files to be UTF8, I can't see any reason why we
can't or shouldn't take the same approach to extension files.

> So, I think no additional complexity will be added even if we
> support a configurable encoding as the third encoding.

This is nonsense. The mere existence of the parameter requires code
to support it and user documentation to explain it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-12-19 16:39:32 Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files)
Previous Message Robert Haas 2010-12-19 16:28:03 Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files)