Re: Count output lines automatically in psql/help.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Count output lines automatically in psql/help.c
Date: 2022-06-10 11:50:37
Message-ID: 2490638.1654861837@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> I wonder whether this mix of HELP0 and HELP is necessary. The original
> code didn't care about calling fprintf even if there are no
> substitutions. I think this could lead to misalignment errors. I
> vaguely recall we once had mixes of fprintf and fputs and got rid of
> them for this reason.

In the committed patch, I changed HELP to HELPN exactly so that
the strings would still line up.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-06-10 13:16:31 Re: better page-level checksums
Previous Message Justin Pryzby 2022-06-10 11:48:45 Re: [PATCH] psql: \dn+ to show size of each schema (and \dA+ for AMs)