Re: elog() proposal

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: elog() proposal
Date: 2002-02-23 16:41:11
Message-ID: 24906.1014482471@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> So, basically, what this comes down to with respect to your patch:

> 1. Renumbering the error codes breaks backward compatibility *silently*.

Perhaps, but it doesn't bother me. We have *never* promised binary
compatibility of server-side extensions across versions; usually,
you should be happy if a recompile is sufficient ;-). (Structs,
for example, are subject to field rearrangement all the time.)

In any case, we could maintain binary compatibility for the old-style
codes (DEBUG, ERROR, etc); this does not force us to use matching
codes for the new PG_ERROR etc. levels.

> 2. CRASH doesn't seem like a good name to me.

Why not? It's short, memorable, accurate, and what's wrong with
a little levity?

> 3. I agree with adding a LOG or INFO level between DEBUG and NOTICE.

Both, I think; they're not the same thing. LOG = routine server
operation notices (eg, "checkpoint starting now"). INFO =
allegedly-helpful messages issued to client (eg, the one about
truncating overlength identifiers). Normal configuration would
be to put one but not the other into the postmaster log.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Lockhart 2002-02-23 16:53:04 Re: elog() proposal
Previous Message Dave Cramer 2002-02-23 15:00:06 Open magazine article on open source rdbms