Re: [BUGS] Bug #926: if old postgresql.jar in CLASSPATH,

Sounds great to me

/Palle

--On fredag, augusti 22, 2003 11.30.54 -0400 Dave Cramer
<Dave(at)micro-automation(dot)net> wrote:

> So if we do a combination of the two, and change the error message to
>
> <fail message="Old driver in jre/lib/ext" if ...
>
> Dave
> On Thu, 2003-08-21 at 23:14, Derek S wrote:
>> The following will do what you're asking:
>>
>> <available classname="org.postgresql.Driver"
>> property="old.driver.present" />
>> <fail message="Old driver on classpath" if="old.driver.present"
>> />
>>
>> Dave Cramer wrote:
>>
>> > I think you are correct, this will not fix 2, is it possible to detect
>> > if a class is present in ant, and fail?
>> >
>> > dave
>> > On Thu, 2003-08-21 at 16:16, Barry Lind wrote:
>> >
>> >
>> >> Can someone explain to me why this change fixes the problem?
>> >>
>> >> I don't understand why including 'includeAntRuntime="no"' in the
>> >> javac tag will cause the compile to no longer pick up old versions
>> >> of the driver that may be around. There are two cases that I am
>> >> familiar with of this problem: 1) there is a old postgresql jdbc
>> >> jar file in the CLASSPATH environment, and 2) there is an old jar in
>> >> the jre/lib/ext directory. I can see where this patch might prevent
>> >> 1 (although the property name and doc aren't very clear on that) but
>> >> I don't see how it would fix 2.
>> >>
>> >> thanks,
>> >> --Barry
>> >>
>> >>
>> >> Dave Cramer wrote:
>> >>
>> >>
>> >>> Yes, agreed
>> >>>
>> >>> Dave
>> >>> On Sun, 2003-08-17 at 09:57, Palle Girgensohn wrote:
>> >>>
>> >>>
>> >>>
>> >>>> It's been in use for the freebsd port for some months now, so I say
>> >>>> yes. ;-)
>> >>>>
>> >>>> /Palle
>> >>>>
>> >>>> lördagen den 16 augusti 2003 kl 22.54 skrev Bruce Momjian:
>> >>>>
>> >>>>
>> >>>>
>> >>>>
>> >>>>> Is this patch valid for inclusion in jdbc?
>> >>>>>
>> >>>>> ------------------------------------------------------------------
>> >>>>> ----- ----
>> >>>>>
>> >>>>> pgsql-bugs(at)postgresql(dot)org wrote:
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>>> Palle Girgensohn (girgen(at)pingpong(dot)net) reports a bug with a
>> >>>>>> severity of 3
>> >>>>>> The lower the number the more severe it is.
>> >>>>>>
>> >>>>>> Short Description
>> >>>>>> if old postgresql.jar in CLASSPATH, ant fails
>> >>>>>>
>> >>>>>> Long Description
>> >>>>>> See http://www.freebsd.org/cgi/query-pr.cgi?pr=48878
>> >>>>>>
>> >>>>>> If there is an older postgresql.jar file in the ant classpath
>> >>>>>> when building a new postgresql.jar, it will fail.
>> >>>>>>
>> >>>>>> Sample Code
>> >>>>>> Adding includeAntRuntime="no" to the compile target in build.xml,
>> >>>>>> as suggested by Tetsurou Okazaki <okazaki(at)FreeBSD(dot)org>, fixes
>> >>>>>> the >> problem
>> >>>>>>
>> >>>>>> --- src/interfaces/jdbc/build.xml~ Sun Oct 20 02:10:55 2002
>> >>>>>> +++ src/interfaces/jdbc/build.xml Mon Mar 3 12:10:37 2003
>> >>>>>> @@ -101,7 +101,7 @@
>> >>>>>>
>> >>>>>> <!-- This is the core of the driver. It is common for all three
>> >>>>>> versions. -->
>> >>>>>> <target name="compile" depends="prepare,check_versions,driver">
>> >>>>>> - <javac srcdir="${srcdir}" destdir="${builddir}"
>> >>>>>> debug="${debug}"> + <javac includeAntRuntime="no"
>> >>>>>> srcdir="${srcdir}"
>> >>>>>> destdir="${builddir}" debug="${debug}">
>> >>>>>> <include name="${package}/**" />
>> >>>>>>
>> >>>>>> <exclude name="${package}/jdbc1/**" unless="jdbc1"/>
>> >>>>>>
>> >>>>>>
>> >>>>>> No file was uploaded with this report
>> >>>>>>
>> >>>>>>
>> >>>>>> ---------------------------(end of
>> >>>>>> broadcast)---------------------------
>> >>>>>> TIP 3: if posting/reading through Usenet, please send an
>> >>>>>> appropriate subscribe-nomail command to majordomo(at)postgresql(dot)org
>> >>>>>> so that your message can get through to the mailing list cleanly
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>> --
>> >>>>> Bruce Momjian | http://candle.pha.pa.us
>> >>>>> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
>> >>>>> + If your life is a hard drive, | 13 Roberts Road
>> >>>>> + Christ can be your backup. | Newtown Square,
>> >>>>> Pennsylvania 19073
>> >>>>>
>> >>>>>
>> >>>> ---------------------------(end of
>> >>>> broadcast)--------------------------- TIP 2: you can get off all
>> >>>> lists at once with the unregister command (send "unregister
>> >>>> YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>> >>>>
>> >>>>
>> >>>>
>> >>
>> >>
>> >>
>>
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 4: Don't 'kill -9' the postmaster
>>
> --
> Dave Cramer <Dave(at)micro-automation(dot)net>
>