Re: Reject wholerow references where ColumnRef is forbidden

Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> writes:
> Here is a fix to some crashes when using a wholerow reference to sneak
> in a ColumnRef where it shouldn't be allowed.

Good catch, but I really don't like this choice:

> Actually instead of calling it from ExpandColumnRefStar, I'm calling it
> from (one of) its callers, since it isn't always necessary.

That's a recipe for future errors of omission; if someone adds another
call of ExpandColumnRefStar, they might copy the wrong pattern.

Another problem is that I'm not sure that every case of "something.*"
produces Vars; foo().* would not, for example. It might be better to
push the check down to someplace like expandNSItemVars.

regards, tom lane