Re: Disallow unique index on system columns

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Disallow unique index on system columns
Date: 2016-04-16 16:13:34
Message-ID: 24896.1460823214@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> On 15 April 2016 at 13:43, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> The attached patch just disallows any index containing a system
>> column, apart from OID.
> Seems I only did half the job as I forgot to think to check for system
> columns that are hidden away inside expressions or predicates.
> The attached fixes that.

Pushed. I moved the check into DefineIndex, as that's where user-facing
complaints about indexes generally ought to be.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2016-04-16 16:22:47 Re: Updated backup APIs for non-exclusive backups
Previous Message Kevin Grittner 2016-04-16 14:15:56 OS scheduler bugs affecting high-concurrency contention