libpq-fe.h should compile *entirely* standalone

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: libpq-fe.h should compile *entirely* standalone
Date: 2023-03-03 17:07:27
Message-ID: 2488193.1677863247@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I realized that headerscheck is failing to enforce $SUBJECT.
This is bad, since we aren't really using libpq-fe.h ourselves
in a way that would ensure that c.h symbols don't creep into it.

We can easily do better, as attached, but I wonder which other
headers should get the same treatment.

regards, tom lane

Attachment Content-Type Size
test-libpq-fe.h-better.patch text/x-diff 732 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-03-03 17:14:25 Re: libpq: PQgetCopyData() and allocation overhead
Previous Message Jeroen Vermeulen 2023-03-03 17:04:22 Re: libpq: PQgetCopyData() and allocation overhead