Re: Re: [COMMITTERS] pgsql: Include the backend ID in the relpath of temporary relations.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Include the backend ID in the relpath of temporary relations.
Date: 2010-08-13 23:23:14
Message-ID: 24817.1281741794@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I have taken a crack at fixing this but someone who understands DTrace
> better than I do may want to check and see if the changes look sane.
> It appears to me that we have no documentation - not even so much as a
> source code comment - explaining how these probes are supposed to work
> or what the arguments to each one are intended mean.

http://developer.postgresql.org/pgdocs/postgres/dynamic-trace.html#DTRACE-PROBE-POINT-TABLE

(... which you now need to update ...)

I think your confusion may stem from the fact that the definition of the
buffer-read-done probe was actually wrong, AFAICS. The docs say its
last 3 args were bools, which was reasonable, but the definition said
int for the first of those. Which is what you want now ...

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-08-14 02:19:58 Re: Re: [COMMITTERS] pgsql: Include the backend ID in the relpath of temporary relations.
Previous Message Robert Haas 2010-08-13 22:58:04 Re: [COMMITTERS] pgsql: Include the backend ID in the relpath of temporary relations.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-08-14 00:20:19 Python 2.7 deprecated the PyCObject API?
Previous Message Robert Haas 2010-08-13 22:58:04 Re: [COMMITTERS] pgsql: Include the backend ID in the relpath of temporary relations.