From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Support custom socket directory in pg_upgrade |
Date: | 2018-11-25 19:36:42 |
Message-ID: | 24815.1543174602@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> [ pg_upgrade_sockdir-v3.patch ]
BTW, I notice that cfbot doesn't like this now that Thomas is running it
with -Werror:
option.c: In function ‘parseCommandLine’:
option.c:265:8: error: ignoring return value of ‘getcwd’, declared with attribute warn_unused_result [-Werror=unused-result]
getcwd(default_sockdir, MAXPGPATH);
^
cc1: all warnings being treated as errors
Failing to check a syscall's result isn't per project style even if
the tools would let you get away with it. Other places in that same
file do
if (!getcwd(cwd, MAXPGPATH))
pg_fatal("could not determine current directory\n");
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2018-11-25 19:40:32 | Re: Updated backup APIs for non-exclusive backups |
Previous Message | Laurenz Albe | 2018-11-25 19:17:30 | Re: Updated backup APIs for non-exclusive backups |