Re: pgsql: Add support for hyperbolic functions, as well as log10().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, laetitia(dot)avrot(at)gmail(dot)com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
Date: 2019-03-13 03:16:42
Message-ID: 24813.1552447002@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Tue, Mar 12, 2019 at 07:55:14PM +0000, Tom Lane wrote:
>> Add support for hyperbolic functions, as well as log10().

> jacana is not a fan of this commit, and failed on float8:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2019-03-13%2000%3A00%3A27
> @@ -476,7 +476,7 @@
> SELECT asinh(float8 '0');
> asinh
> -------
> - 0
> + -0
> (1 row)

Yeah. I warned Laetitia about not testing corner cases, but
it hadn't occurred to me that zero might be a corner case :-(

I'm inclined to leave it as-is for a day or so and see if any
other failures turn up, before deciding what to do about it.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-03-13 05:03:31 Re: pgsql: Add support for hyperbolic functions, as well as log10().
Previous Message Michael Paquier 2019-03-13 02:21:59 Re: pgsql: Add support for hyperbolic functions, as well as log10().

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-03-13 04:08:01 Re: BUG #15668: Server crash in transformPartitionRangeBounds
Previous Message Kuroda, Hayato 2019-03-13 02:52:19 RE: ECPG regression with DECLARE STATEMENT support