Re: Support for %TYPE in CREATE FUNCTION

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ian Lance Taylor <ian(at)airs(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Support for %TYPE in CREATE FUNCTION
Date: 2001-05-30 17:25:16
Message-ID: 24809.991243516@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Ian Lance Taylor <ian(at)airs(dot)com> writes:
> I have a meta-point: the choices to be made here are not all that
> interesting. They do have to be defined. But almost any definition
> is OK.

Well, that implicit assumption is exactly the one I was questioning;
*is* it OK not to be very concerned about what the behavior is? ISTM
that how the system handles these cases will constrain the use of the
%TYPE feature into certain pathways. The limitations arising from your
original patch presumably don't matter for your intended use, but they
may nonetheless be surprising for people who try to use it differently.
(We've seen cases before where someone does a quick-and-dirty feature
addition that fails to act as other people expect it to.)

I wanted to see a clear understanding of what the corner-case behavior
is, and a consensus that that behavior is acceptable all 'round. If
the quick-and-dirty route will be satisfactory over the long run, fine;
but I don't much want to install a new feature that is immediately going
to draw bug reports/upgrade requests/whatever you want to call 'em.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Don Baccus 2001-05-30 17:48:20 Re: Support for %TYPE in CREATE FUNCTION
Previous Message Bruce Momjian 2001-05-30 17:14:58 Re: Support for %TYPE in CREATE FUNCTION

Browse pgsql-patches by date

  From Date Subject
Next Message Don Baccus 2001-05-30 17:48:20 Re: Support for %TYPE in CREATE FUNCTION
Previous Message Bruce Momjian 2001-05-30 17:14:58 Re: Support for %TYPE in CREATE FUNCTION