| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ICU locales and text/char(n) SortSupport on Windows |
| Date: | 2017-09-21 19:12:35 |
| Message-ID: | 24766dc5-5cf4-d0e4-ad6a-53fda20414c6@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/16/17 18:33, Peter Geoghegan wrote:
> In summary, we're currently attaching the use of SortSupport to the
> wrong thing. We're treating this UTF-16 business as something that
> implies a broad OS/platform restriction, when in fact it should be
> treated as implying a restriction for one particular collation
> provider only (a collation provider that happens to be built into
> Windows, but isn't really special to us).
>
> Attached patch shows what I'm getting at. This is untested, since I
> don't use Windows. Proceed with caution.
Your analysis makes sense, but the patch doesn't work, because "locale"
is never set before reading it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-09-21 19:21:57 | Re: ICU locales and text/char(n) SortSupport on Windows |
| Previous Message | Tom Lane | 2017-09-21 18:58:09 | Re: [COMMITTERS] pgsql: Fix bool/int type confusion |