Re: Exposing PG_VERSION_NUM in pg_config

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Exposing PG_VERSION_NUM in pg_config
Date: 2015-03-31 19:09:34
Message-ID: 24730.1427828974@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, Mar 31, 2015 at 9:40 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> I'm interested in the exact syntax you'd use, to compare it to the
>> currently used techniques.

> With the presence of VERSION_NUM directly in pg_config, the following
> expression:
> VERSION_NUM=$(shell $(PG_CONFIG) --version-num)

> With its presence in Makefile.global, that's close to what you can do with
> pg_config.h already:
> VERSION_NUM := $(shell cat `$(PG_CONFIG) --libdir`/pgxs/src/Makefile.global
> \
> | perl -ne 'print $$1 and exit if /VERSION_NUM =\s+(\d+)/')
> But that looks a little bit magic..

I'm confused. If PG_VERSION_NUM is defined in Makefile.global, surely
you don't need anything at all to make use of it in extension makefiles.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2015-03-31 19:22:39 Re: Bug fix for missing years in make_date()
Previous Message Peter Eisentraut 2015-03-31 19:09:26 clang -fsanitize=undefined error in ecpg