From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
Subject: | Re: object description for FDW user mappings |
Date: | 2015-03-05 16:32:46 |
Message-ID: | 24688.1425573166@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> When commit cae565e503 introduced FDW user mappings, it used this in
> getObjectDescription for them:
> appendStringInfo(&buffer, _("user mapping for %s"), usename);
> This was later mostly copied (by yours truly) as object identity by
> commit f8348ea32e wherein I used this:
> appendStringInfo(&buffer, "%s", usename);
> As it turns out, this is wrong, because the pg_user_mapping catalog has
> a two-column "primary key" which is user OID and server OID. Therefore
> it seems to me that the correct object description and identity must
> include both username and server name. I propose we change the above to
> this:
> appendStringInfo(&buffer, _("user mapping for %s in server %s"), usename,
> srv->servername);
+1 for the concept, but to be nitpicky, "in" doesn't seem like the right
word here. "on server" would read better to me; or perhaps "at server".
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2015-03-05 16:36:41 | Re: MD5 authentication needs help |
Previous Message | Stephen Frost | 2015-03-05 16:26:33 | Re: MD5 authentication needs help |