Re: pg_get_viewdefs() indentation considered harmful

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_get_viewdefs() indentation considered harmful
Date: 2014-04-30 17:47:57
Message-ID: 24649.1398880077@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> I'm still dubious about halving the step distance, because there are
> assorted places that adjust the indentation of specific keywords by
> distances that aren't a multiple of 2 (look for odd last arguments to
> appendContextKeyword). I'm not sure how that will look after we make such
> a change. Possibly it would work to only apply the scale factor to
> context->indentLevel, and not the indentPlus number?

I pushed a patch that does it that way, and also patches for the other
items discussed in this thread.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2014-04-30 17:58:29 Re: GSoC on WAL-logging hash indexes
Previous Message Robert Haas 2014-04-30 17:11:55 Re: [HACKERS] GSoC on WAL-logging hash indexes