| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, didier <did447(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, buildfarm(at)coelho(dot)net |
| Subject: | Re: LLVM compile failing in seawasp |
| Date: | 2019-07-28 13:54:05 |
| Message-ID: | 24644.1564322045@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
> Otherwise, why not simply move llvm C++ includes *before* postgres
> includes?
We've been burnt in the past by putting other headers before postgres.h.
(A typical issue is that the interpretation of <stdio.h> varies depending
on _LARGE_FILES or a similar macro, so you get problems if something
causes that to be included before pg_config.h has set that macro.)
Maybe none of the platforms where that's an issue have C++, but that
doesn't seem like a great assumption.
> They should be fully independent anyway, so the order should
> not matter?
On what grounds do you claim that's true anywhere, let alone
everywhere?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-07-28 14:07:27 | Re: Add parallelism and glibc dependent only options to reindexdb |
| Previous Message | Tomas Vondra | 2019-07-28 10:15:20 | Re: ANALYZE: ERROR: tuple already updated by self |