| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-11-06 15:32:02 |
| Message-ID: | 24643.1541518322@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Tue, Nov 6, 2018 at 6:23 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> What I suggest is that we *not* try to make this a completely transparent
>> substitute. Instead, make the functions exported by src/port/ be
>> "pg_pread" and "pg_pwrite", ...
> OK. But since we're using this from both fd.c and xlog.c, I put that
> into src/include/port.h.
LGTM. I didn't bother to run an actual test cycle, since it's not
materially different from the previous version as far as portability
is concerned.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Raiskup | 2018-11-06 15:41:16 | Re: plruby: rb_iterate symbol clash with libruby.so |
| Previous Message | Surafel Temesgen | 2018-11-06 15:23:19 | Re: pg_dump multi VALUES INSERT |