Re: pgsql: Add pg_sequence system catalog

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add pg_sequence system catalog
Date: 2016-12-20 20:32:19
Message-ID: 24589.1482265939@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> It looks like the catalog data is written without padding (relid(4),
> start(8), inc(8), max(8), min(8), ...) but read with padding (relid(4),
> padding(4), start(8), inc(8), max(8), min(8), ...). The difference is
> that the write goes through heap_form_tuple but the read uses the Form_
> struct. What is suspicious is this from the configure output:

> checking alignment of short... 2
> checking alignment of int... 4
> checking alignment of long... 4
> checking alignment of long long int... 8
> checking alignment of double... 4

> We use DOUBLEALIGN to align int64 values, but on this platform, that is
> not correct.

Quickest solution might be to reorder the columns of pg_sequence to
avoid wasting padding bytes, ie, put seqcycle after seqrelid.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-12-20 23:54:18 pgsql: Fix minor error message style violation.
Previous Message Peter Eisentraut 2016-12-20 17:57:33 Re: pgsql: Add pg_sequence system catalog

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2016-12-20 20:43:11 Re: Clarifying "server starting" messaging in pg_ctl start without --wait
Previous Message Ryan Murphy 2016-12-20 20:31:50 Clarifying "server starting" messaging in pg_ctl start without --wait