From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: danger of stats_temp_directory = /dev/shm |
Date: | 2013-08-19 18:56:05 |
Message-ID: | 24568.1376938565@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-08-19 14:28:28 -0400, Tom Lane wrote:
>> One possibility is to do the initial check somewhere shortly after
>> ChangeToDataDir(), and have the GUC check hook only attempt to make a
>> check in SIGHUP context. Unfortunately we aren't passing the context to
>> check hooks, only GucSource which isn't adequate for this. Not sure if we
>> want to go so far as to change the check-hook API at this point. We could
>> probably think of some other, klugy way to tell if it's initial startup.
> Is it even actually safe to have stats_temp_directory PGC_SIGHUP after
> the per DB splitup? I haven't audited the code for it, but it seems
> somewhat likely that we would end up with some files in the old and some
> in the new directory?
That's a good point. For the moment we could just change it to
PGC_POSTMASTER and eliminate this problem. Reducing it back to SIGHUP
would be a future feature, which is evidently less than trivial.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Boszormenyi Zoltan | 2013-08-19 19:02:21 | Re: [GENERAL] currval and DISCARD ALL |
Previous Message | Andres Freund | 2013-08-19 18:39:50 | Re: danger of stats_temp_directory = /dev/shm |