Re: [HACKERS] wrong t_bits alignment in pageinspect

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Maksim Milyutin <milyutinma(at)gmail(dot)com>
Cc: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] wrong t_bits alignment in pageinspect
Date: 2018-01-04 20:03:06
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Maksim Milyutin <milyutinma(at)gmail(dot)com> writes:
> Attached a new version of patch with regression test.

Looks good, pushed.

I also removed one error check from tuple_data_split --- there doesn't
seem to be a lot of point in checking that bits_str_len is some multiple
of 8 when we're about to check that it's equal to a particular multiple
of 8.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message PG Bug reporting form 2018-01-04 20:06:33 BUG #14999: pg_rewind corrupts control file global/pg_control
Previous Message Fabrízio de Royes Mello 2018-01-04 19:42:56 Re: bug? import foreign schema forgets to import column description