Re: Fixing order of resowner cleanup in 12, for Windows

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> A while back I posted a patch[1] to change the order of resowner
> cleanup so that DSM handles are released last. That's useful for the
> error cleanup path on Windows, when a SharedFileSet is cleaned up (a
> mechanism that's used by parallel CREATE INDEX and parallel hash join,
> for spilling files to disk under a temporary directory, with automatic
> cleanup).

I guess what I'm wondering is if there are any potential negative
consequences, ie code that won't work if we change the order like this.
I'm finding it hard to visualize what that would be, but then again
this failure mode wasn't obvious either.

> I suppose we probably should make the change to 12 though: then owners
> of extensions that use DSM detach hooks (if there any such extensions)
> will have a bit of time to get used to the new order during the beta
> period. I'll need to find someone to test this with a fault injection
> scenario on Windows before committing it, but wanted to sound out the
> list for any objections to this late change?

Since we haven't started beta yet, I don't see a reason not to change
it. Worst case is that it causes problems and we revert it.

I concur with not back-patching, in any case.

regards, tom lane