Re: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader

Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> I think I'm with Heikki on this one. Dumping xlog data is useful, but
>> it's really for developers and troubleshooters, not something we
>> expect people to do on a regular basis, so contrib seems appropriate.

> There are two downsides for contrib rather than src/bin. First,
> maintainance and user trust are easier done and achieved in src/bin.

User trust, maybe, but the "maintenance" argument seems bogus.
We ship contrib on the same release schedule as core.

> Second, a lot of users won't install contribs in their production server
> and will then miss the tool when they need it most.

TBH, I don't believe that ordinary users will need this tool at all,
ever, and thus I don't want it in src/bin/. From a packaging standpoint
it will be a lot easier if it's in contrib ... otherwise I'll probably
have to invent some new sub-RPM along the lines of postgresql-extras
so as to avoid bloating the core server package.

regards, tom lane