Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: 2021-10-09 19:44:17
Message-ID: 245162.1633808657@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On Fri, Oct 08, 2021 at 12:03:41PM -0400, Tom Lane wrote:
>> You're not going to get far with "improving the recipe", because it's
>> just not possible. To check this, I installed perlbrew on a Fedora 34

> Your test result is evidence that "cpanm install Test::More(at)0(dot)87" is the wrong
> shell command, but it's quite a leap to "just not possible". Surely there
> exist other shell commands that install
> http://backpan.perl.org/modules/by-authors/id/M/MS/MSCHWERN/Test-Simple-0.87_03.tar.gz.
> (Perhaps none of us will care enough to identify them, but they exist.)

Oh, I never heard of backpan before. Now I'm tempted to see how far
I can downgrade prairiedog before it breaks ;-). However, I agree
that most people won't care about that, and probably shouldn't need to.

> By the way, I suspect 93fb39e introduced a regression in the recipe. (I
> haven't tested, though.) Before commit 93fb39e, "cpanm install IPC::Run"
> would update Test::More. As of 5.8.3, the core version of Test::More is new
> enough for IPC::Run but not new enough for PostgreSQL. I recommend adding
> "cpanm install Test::More" to restore the pre-93fb39e functionality.

Good point. So how about like the attached?

regards, tom lane

Attachment Content-Type Size
improve-test-perl-README-2.patch text/x-diff 1.7 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2021-10-09 19:59:47 Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Previous Message Noah Misch 2021-10-09 19:23:33 Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2021-10-09 19:59:47 Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Previous Message Noah Misch 2021-10-09 19:23:33 Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.