| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "bigbro_wq(at)hotmail(dot)com" <bigbro_wq(at)hotmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Repeat the condition check twice in function distribute_qual_to_rels |
| Date: | 2024-11-03 19:07:02 |
| Message-ID: | 2447691.1730660822@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"bigbro_wq(at)hotmail(dot)com" <bigbro_wq(at)hotmail(dot)com> writes:
> I notice that check the condtion again when after invoked process_equivalence and return failed.
> /* EC rejected it, so set left_ec/right_ec the hard way ... */
> if (restrictinfo->mergeopfamilies) /* EC might have changed this */
> Above the codes, check the condition again when invoked process_equivalence failed,
> but it's already under the positive condition "if (restrictinfo->mergeopfamilies)".
> It's necessary ?
Yes. See commit 8ec5429e2: the restrictinfo might now be
completely different from what it was.
(You could have discovered this for yourself by removing
the test and seeing what happened.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-11-03 19:36:28 | Re: Time to add a Git .mailmap? |
| Previous Message | Tom Lane | 2024-11-03 18:42:33 | Re: EphemeralNamedRelation and materialized view |