Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> If it does produce the log message, then the attached patch should
> make it go away.
One thing I don't care for about this patch is that the original code
looked like it didn't matter what order we did the resource releases in,
and the patched code still looks like that. You're not doing future
hackers any service by failing to include a comment that explains that
DSM detach MUST BE LAST, and explaining why. Even with that, I'd only
rate it about a 75% chance that somebody won't try to add their new
resource type at the end --- but with no comment, the odds they'll
get it right are indistinguishable from zero.
regards, tom lane