| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Comment on GatherPath.single_copy |
| Date: | 2016-08-30 13:08:34 |
| Message-ID: | 24467.1472562514@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> - bool single_copy; /* path must not be executed >1x */
> + bool single_copy; /* path must not span on multiple processes */
I agree that the existing comment sucks, but this isn't a lot better
(and it will probably not look nice after pgindent gets done with it).
Possibly it's too complicated to jam a reasonable explanation into the
same-line comment, and what is needed is to expand the sentence about
it in the comment above the struct.
Robert, could you fix the documentation for that field so it's
intelligible?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-08-30 13:18:05 | Re: Missing checks when malloc returns NULL... |
| Previous Message | Michael Paquier | 2016-08-30 13:06:05 | Re: standalone backend PANICs during recovery |