| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, tejeswarm(at)hotmail(dot)com, Andres Freund <andres(at)anarazel(dot)de>, hlinnaka <hlinnaka(at)iki(dot)fi>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Daniel Wood <hexexpert(at)comcast(dot)net> |
| Subject: | Re: Corruption during WAL replay |
| Date: | 2021-09-24 20:22:28 |
| Message-ID: | 2444346.1632514948@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Sep 24, 2021 at 3:42 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think the basic idea is about right, but I'm not happy with the
>> three-way delayChkpt business; that seems too cute by three-quarters.
> Nobody, but the version of the patch that I was looking at uses a
> separate bit for each one:
> +/* symbols for PGPROC.delayChkpt */
> +#define DELAY_CHKPT_START (1<<0)
> +#define DELAY_CHKPT_COMPLETE (1<<1)
Hm, that's not in the patch version that the CF app claims to be
latest [1]. It does this:
+/* type for PGPROC.delayChkpt */
+typedef enum DelayChkptType
+{
+ DELAY_CHKPT_NONE = 0,
+ DELAY_CHKPT_START,
+ DELAY_CHKPT_COMPLETE
+} DelayChkptType;
which seems like a distinct disimprovement over what you're quoting.
regards, tom lane
[1] https://www.postgresql.org/message-id/20210106.173327.1444585955309078930.horikyota.ntt@gmail.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2021-09-24 20:27:42 | Re: .ready and .done files considered harmful |
| Previous Message | Robert Haas | 2021-09-24 20:08:44 | Re: Corruption during WAL replay |