| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Mario Emmenlauer <mario(at)emmenlauer(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: dup(0) fails on Ubuntu 20.04 and macOS 10.15 with 13.0 |
| Date: | 2021-09-02 23:00:46 |
| Message-ID: | 2440671.1630623646@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Mario Emmenlauer <mario(at)emmenlauer(dot)de> writes:
> The idea to switch to dup(2) sounds very good to me.
I poked at this some more, and verified that adding "fclose(stdin);"
at the head of PostmasterMain is enough to trigger the reported
failure. However, after changing fd.c to dup stderr not stdin,
we can pass check-world even with that in place. So that confirms
that there is no very good reason for the postmaster to require
stdin to be available.
Hence, I pushed the fix to make fd.c use stderr here. I only
back-patched to v14, because given the lack of other complaints,
I couldn't quite justify touching stable branches for this.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2021-09-02 23:08:52 | Re: Query takes around 15 to 20 min over 20Lakh rows |
| Previous Message | Michael Lewis | 2021-09-02 22:27:14 | Re: Query takes around 15 to 20 min over 20Lakh rows |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-03 00:09:16 | Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters |
| Previous Message | Phil Krylov | 2021-09-02 22:57:16 | Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters |