Re: Why do pg_upgrade's test use the serial schedule?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: Why do pg_upgrade's test use the serial schedule?
Date: 2018-11-05 22:08:12
Message-ID: 2434.1541455692@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-11-05 16:32:20 -0500, Tom Lane wrote:
>> It's injected via the TEMP_CONFIG env variable.

> Ah, thanks. Is there any good reason to not instead have it in the
> script?

Why that script in particular? If you don't want fsync, you likely
don't want it across the entire check-world run. The TEMP_CONFIG
thing is a hack no doubt, but it gets the job done globally. Also,
if you *do* want fsync, there's one place to turn it back on. I'm
not a fan of individual tests deciding they know what to do.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-11-05 22:11:42 Re: Why do pg_upgrade's test use the serial schedule?
Previous Message Andres Freund 2018-11-05 22:00:30 Re: Why do pg_upgrade's test use the serial schedule?