From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Another pgindent request |
Date: | 2001-09-04 03:00:52 |
Message-ID: | 24330.999572452@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
As long as you're hacking pgindent, can you do something about its habit
of sometimes removing all space before a same-line comment? Here's
an example from the 7.1 run (in src/backend/storage/lmgr/proc.c):
***************
*** 607,613 ****
MyProc->waitHolder = holder;
MyProc->waitLockMode = lockmode;
! MyProc->errType = STATUS_OK; /* initialize result for success */
/* mark that we are waiting for a lock */
waitingForLock = true;
--- 612,618 ----
MyProc->waitHolder = holder;
MyProc->waitLockMode = lockmode;
! MyProc->errType = STATUS_OK;/* initialize result for success */
/* mark that we are waiting for a lock */
waitingForLock = true;
***************
IMHO there should always be at least one space before a same-line
comment.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-09-04 03:05:54 | Re: Another pgindent request |
Previous Message | Bruce Momjian | 2001-09-04 02:14:50 | Re: Bytea/Base64 encoders for libpq - interested? |