| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Joachim Wieland <joe(at)mcknight(dot)de>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Kris Jurka <books(at)ejurka(dot)com> |
| Subject: | Re: Hot Standy introduced problem with query cancel behavior |
| Date: | 2009-12-29 16:13:03 |
| Message-ID: | 24182.1262103183@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On Tuesday 29 December 2009 16:22:54 Tom Lane wrote:
>> This seems like a fairly bad idea. One of the intended use-cases is to
>> be able to manually "kill -INT" a misbehaving backend. Assuming that
>> there will be valid info about the signal in shared memory will break
>> that.
> Well. That already is the case now. MyProc->recoveryConflictMode is checked to
> recognize what kind of conflict is being resolved...
In that case, HS has already broken it, and we need to fix it not make
it worse.
My humble opinion is that SIGINT should not be overloaded with multiple
meanings. We already have a multiplexed signal mechanism, which is what
should be used for any additional signal reasons HS may need to
introduce.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2009-12-29 16:57:15 | quoting psql varible as identifier |
| Previous Message | Andres Freund | 2009-12-29 16:04:13 | Re: Hot Standy introduced problem with query cancel behavior |