Re: Fairly serious bug induced by latest guc enum changes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Fairly serious bug induced by latest guc enum changes
Date: 2008-05-13 13:50:29
Message-ID: 24182.1210686629@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Okay, but you failed to correctly reproduce the conditions for closing
> the old file.

A more bulletproof solution might involve passing sync_method to
get_sync_bit as an explicit parameter, and then the assign hook
could do
if (get_sync_bit(sync_method) != get_sync_bit(new_sync_method))
XLogFileClose();

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2008-05-13 13:54:21 Re: Fairly serious bug induced by latest guc enum changes
Previous Message Tom Lane 2008-05-13 13:44:14 Re: Fairly serious bug induced by latest guc enum changes