Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> oops, I just saw that you have already pushed a fix for it. I am not
> sure if we should try to do anything about walrcv_receive's output
> still uses pgsocket instead of int as the usage in itself doesn't have
> any problem.
I see a few places where we're still assigning PQsocket's result to a
pgsocket variable, but none of them are worrying about the possibility
that it's not a valid socket, and I'm not sure they need to.
regards, tom lane