From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Documentation improvements for partitioning |
Date: | 2017-02-20 02:22:08 |
Message-ID: | 23da68eb-6f71-39df-8b1e-f5b251a12291@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2017/02/20 1:04, Robert Haas wrote:
> On Thu, Feb 16, 2017 at 12:43 PM, Amit Langote wrote:
>> So I count more than a few votes saying that we should be able to DROP
>> partitioned tables without specifying CASCADE.
>>
>> I tried to implement that using the attached patch by having
>> StoreCatalogInheritance1() create DEPENDENCY_AUTO dependency between
>> parent and child if the child is a partition, instead of DEPENDENCY_NORMAL
>> that would otherwise be created. Now it seems that that is one way of
>> making sure that partitions are dropped when the root partitioned table is
>> dropped, not sure if the best; why create the pg_depend entries at all one
>> might ask. I chose it for now because that's the one with fewest lines of
>> change. Adjusted regression tests as well, since we recently tweaked
>> tests [1] to work around the irregularities of test output when using CASCADE.
>
> Could you possibly post this on a new thread with a reference back to
> this one? The number of patches on this one is getting a bit hard to
> track, and some people may be under the misimpression that this one is
> just about documentation.
Sorry about that. Sent the above message and the patch in a new thread
titled "dropping partitioned tables without CASCADE" [1].
Thanks,
Amit
[1] https://postgr.es/m/6c420206-45d7-3f56-8325-4bd7b76483ba%40lab.ntt.co.jp
From | Date | Subject | |
---|---|---|---|
Next Message | Jim Nasby | 2017-02-20 02:27:06 | Re: Adding new output parameter of pg_stat_statements to identify operation of the query. |
Previous Message | Amit Kapila | 2017-02-20 02:22:04 | Re: Instability in select_parallel regression test |