| From: | miyake_kouta <miyake_kouta(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] pgbench: improve \sleep meta command |
| Date: | 2021-03-05 01:51:04 |
| Message-ID: | 23b254daf20cec4332a2d9168505dbc9@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
I created a patch to improve \sleep meta command in pgbench.
There are two problems with the current pgbench implementation of
\sleep.
First, when the input is like "\sleep foo s" , this string will be
treated as 0 through atoi function, and no error will be raised.
Second, when the input is like "\sleep :some_bool s" and some_bool is
set to True or False, this bool will be treated as 0 as well.
However, I think we should catch this error, so I suggest my patch to
detect this and raise errors.
Regards.
--
Kota Miyake
| Attachment | Content-Type | Size |
|---|---|---|
| v01_pgbench_sleep.patch | text/x-diff | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | walker | 2021-03-05 01:55:53 | Re: make coverage-html would fail within build directory separate from source tree |
| Previous Message | Amit Kapila | 2021-03-05 01:46:07 | Re: Parallel INSERT (INTO ... SELECT ...) |