From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Lyes Ameddah <lyes(dot)amd(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: BUG #14941: Vacuum crashes |
Date: | 2018-04-05 20:29:38 |
Message-ID: | 239EE2DC-9FB3-4CB2-92AC-94E035F8BCB1@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On 3/30/18, 7:19 PM, "Andres Freund" <andres(at)anarazel(dot)de> wrote:
> Could you post a rebased version of the patch, with an incremental
> addition of what you propose in a separate patch?
Here is a new patch set. I have attempted to add skip-locked
functionality everywhere it is needed, including VACUUM FULL.
On 4/3/18, 12:12 AM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> On Fri, Mar 30, 2018 at 05:19:46PM -0700, Andres Freund wrote:
>> On 2018-03-30 18:39:01 +0000, Bossart, Nathan wrote:
>>> I think the most straightforward approach for fixing this is to add
>>> skip-locked functionality in find_all_inheritors(),
>>> find_inheritance_children(), and vac_open_indexes(), but I am curious
>>> what others think.
>
> For vac_open_indexes() it may make the most sense to introduce a new
> try_open_index which wraps on top of try_relation_open with checks on
> the opened relation's relkind.
I looked into this, but I noticed that the analogous
try_relation_open() implements missing-ok for relation_open(). So, I
thought it might be confusing to have try_index_open() be a skip-
locked version of index_open().
The new tests are now passing as expected, but I am still doing some
manual testing. Since there is quite a bit of added complexity in
this new patch set, I will certainly not be surprised if this gets
moved to the next commitfest.
Nathan
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-04-05 21:41:14 | Re: BUG #14941: Vacuum crashes |
Previous Message | Andrew Gierth | 2018-04-05 14:57:08 | Re: BUG #15142: ERROR: MultiXactId nnnnn has not been created yet -- apparent wraparound in v9.5 |
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2018-04-05 20:35:23 | Re: WIP: a way forward on bootstrap data |
Previous Message | John Naylor | 2018-04-05 20:28:10 | Re: WIP: a way forward on bootstrap data |