| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, David Fetter <david(at)fetter(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Win32 sysconfig -> pg_service.conf |
| Date: | 2006-06-06 22:52:28 |
| Message-ID: | 23987.1149634348@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> On Win32, patch applied to return path if GetShortPathName() fails (no
> short name, path does not exist), rather than returning nothing.
Hm, are you sure GetShortPathName will never modify the path before
failing? For instance, I'd be a bit worried about cases where it
successfully adjusts some components of the path before finding one that
doesn't exist.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2006-06-07 00:03:38 | Re: That EXPLAIN ANALYZE patch still needs work |
| Previous Message | Bruce Momjian | 2006-06-06 22:34:03 | Re: [HACKERS] Win32 sysconfig -> pg_service.conf |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Qingqing Zhou | 2006-06-07 01:34:47 | Re: remove lock protection on HeapTupleSatisfiesVacuum |
| Previous Message | Andrew Dunstan | 2006-06-06 22:35:15 | Re: [HACKERS] Win32 sysconfig -> pg_service.conf |