Re:Re:Re: Propose: Adding a '--enable-failover' option to 'pg_createsubscriber' ver.3

At 2025-12-11 15:13:40, "Xueyu Gao" <gaoxueyu_hope(at)163(dot)com> wrote:

At 2025-12-11 14:39:16, "Ioseph Kim" <pgsql-kr(at)postgresql(dot)kr> wrote:
>Hi
>
>TAP test codes are added in the patch
>and manual has become more user-friendly.
>
>Please review the patch and let me know if you see a better solution. I’ll be glad to update it accordingly.
>
>ioseph
>
>On Wed, Dec 10, 2025 at 06:03:48PM +0900, Ioseph Kim wrote:
>> Hi
>>
>> A failover option has been added to the CREATE SUBSCRITION command, but this functionality isn't easily accessible using the pg_createsubscriber tool.
>>
>> Subscriptions created using pg_createsubscriber must be configured for failover via an alter operation.
>>
>> To address this issue, we've added a simple --enable-failover option to the pg_createsubscriber tool.
>>
>> This patch is simple. It doesn't handle exceptions or provide any TAP test code.
>>
>> Please review this and we hope the development team will refine it further.
>>

>> ioseph

Hi, ioseph,

I took a look at the doc part and have two comments.

/doc/src/sgml/ref/pg_createsubscriber.sgml

1. "The default is <literal>false</literal>" , it'd be better to add "value" after the "default".

2. I think the following content should be surrounded by <para> and </para>, so the <para> should be moved to be in front of "When this option is enabled..."

+ When this option is enabled, the connection string used in the <option>--publisher-server</option>

+ option may be adjusted to support failover. For example, by specifying multiple hosts

+ and using <literal>target_session_attrs=read-write</literal>.

+ <para>

+ </para>

+ </listitem>

+ </varlistentry>
Thanks,
Xueyu Gao

One more comment:

src/bin/pg_basebackup/t/040_pg_createsubscriber.pl

+ 'replication slot are created with the failover option enabled');

This sentence should be "replication slots are ..."
Thanks,
Xueyu Gao