Re: Something in our JIT code is screwing up PG_PRINTF_ATTRIBUTE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Something in our JIT code is screwing up PG_PRINTF_ATTRIBUTE
Date: 2025-12-06 20:40:25
Message-ID: 2381662.1765053625@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> On 4 Dec 2025, at 19:01, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> On the other hand, aligning the C++ compiler with the C compiler
>> is likely to avoid other problems, so maybe it's better to focus
>> on making that happen. I'm not sure how we'd do that automatically
>> though.

> It sounds pretty complicated to, with confidence, automatically detect this.

Yeah. However, selecting different PG_PRINTF_ATTRIBUTE values for
C and C++ mode seems to get the job done. I've confirmed the attached
silences these warnings for me when mixing-and-matching gcc and clang.

I don't have a lot of faith in the meson.build addition being correct,
though it worked in a simple test. Anyone want to review that?

regards, tom lane

Attachment Content-Type Size
v1-separate-c-and-cxx-printf-archetypes.patch text/x-diff 9.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-12-06 20:47:59 Re: Strict functions with variadic "any" argument bug
Previous Message Peter Geoghegan 2025-12-06 20:04:20 Re: Moving _bt_readpage and _bt_checkkeys into a new .c file