Dominik Czarnota <dominik(dot)b(dot)czarnota(at)gmail(dot)com> writes:
> This patch fixes a size parameter of `pg_strncasecmp` which compared a
> "string" literal with a variable by passing a size of 5 while the "string"
> literal has 6 bytes.
Pushed, thanks for the report!
> By the way, the `strncasecmp` usages around the fixed line could use
> `strcasecmp` which doesn't accept the `size_t n` argument.
Maybe. It's not clear to me that it's be okay to assume that the
variable input string is null-terminated.
regards, tom lane