Re: VACUUM VERBOSE FSM info

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: VACUUM VERBOSE FSM info
Date: 2005-04-23 23:18:08
Message-ID: 23725.1114298288@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Should the "memory used" line be a hint?

Well, the main message should fit on one line, and the rest is either
hint or detail. In this case detail since it's all facts, not advice.
Could look like this:

INFO: free space map contains N1 pages in N2 relations
DETAIL: A total of N3 FSM page slots are in use.
A total of N4 FSM page slots are required to track all free space.
Current FSM parameters are max_fsm_pages = N5, max_fsm_relations = N6,
resulting in total memory usage of N7 kB.

(where N3 is the number including overhead, and N4 is the "requested"
number.)

You could fix it so that hints were conditionally added like

HINT: max_fsm_pages is too small, consider raising it to at least N4.

but since you seem to want to treat that as a WARNING, it'd probably
be redundant to make a HINT for it.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-04-24 03:51:04 Re: VACUUM VERBOSE FSM info
Previous Message Tom Lane 2005-04-23 22:29:54 Re: VACUUM VERBOSE FSM info