Bizarre reindex_relation API

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Bizarre reindex_relation API
Date: 2011-04-16 15:52:47
Message-ID: 2361.1302969167@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Why in the world is reindex_relation defined like this?

#define REINDEX_CHECK_CONSTRAINTS 0x1
#define REINDEX_SUPPRESS_INDEX_USE 0x2
extern bool reindex_relation(Oid relid, bool toast_too, int flags);

Seems like a rational design would have folded toast_too in as another
flag bit, instead of keeping it a separate argument.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2011-04-16 16:48:08 Re: Broken HOT chains in system catalogs
Previous Message Tom Lane 2011-04-16 15:17:53 Re: Broken HOT chains in system catalogs