| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Spurious "apparent wraparound" via SimpleLruTruncate() rounding |
| Date: | 2021-01-01 18:05:29 |
| Message-ID: | 23599722-1EFF-4B71-A77C-67141882EFAE@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Noah!
I've found this thread in CF looking for something to review.
> 9 нояб. 2020 г., в 09:53, Noah Misch <noah(at)leadboat(dot)com> написал(а):
>
> Rebased both patches, necessitated by commit c732c3f (a repair of commit
> dee663f). As I mentioned on another branch of the thread, I'd be content if
> someone reviews the slru-truncate-modulo patch and disclaims knowledge of the
> slru-truncate-insurance patch; I would then abandon the latter patch.
> <slru-truncate-modulo-v5.patch><slru-truncate-t-insurance-v4.patch>
Commit c732c3f adds some SYNC_FORGET_REQUESTs.
slru-truncate-modulo-v5.patch fixes off-by-one error in functions like *PagePrecedes(int page1, int page2).
slru-truncate-t-insurance-v4.patch ensures that off-by-one errors do not inflict data loss.
While I agree that fixing error is better than hiding it, I could not figure out how c732c3f is connected to these patches.
Can you please give me few pointers how to understand this connection?
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alastair Turner | 2021-01-01 18:26:36 | Re: Proposed patch for key management |
| Previous Message | Zhihong Yu | 2021-01-01 17:58:43 | Re: poc - possibility to write window function in PL languages |