Re: Modernizing pg_bsd_indent's error/warning reporting code

Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> writes:
> On Fri, 12 Jun 2026 at 22:29, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> This is not an unreasonable suggestion, and presumably more people
>> will start seeing this as they adopt newer clang versions. (I see
>> the same on Fedora 44, for instance.) So I think we ought to take
>> the advice, and while we're at it let's convert this code to use
>> varargs instead of several duplicative functions. Patch attached.

> Patch looks good to me,

Thanks for looking!

> Just a minor comment, while we are at it, should we change
> the %zd to %zu for nitems since it looks like it uses size_t?

Seems reasonable enough. It can't matter functionally, since
the denominators in nitems() are surely at least 2. But it is
indeed customary to print size_t with %zu, so done that way.

regards, tom lane