Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
Date: 2019-05-20 17:46:55
Message-ID: 23559.1558374415@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-05-21 01:43:35 +0900, Fujii Masao wrote:
>> Thanks for the commit! And sorry, make check-world took very long time
>> and has just finished right now in my env... I'd like to confirm that
>> make check-world reports no error just in case.

> make -j16 -s && make -Otarget -j10 -s check-world && echo success || echo fail

> makes that much more bearable, by running the slow TAP tests in
> parallel. Doesn't work < 10 though.

Yeah, parallelization makes all the difference in the world, assuming
you have a multi-core machine. You can parallelize within TAP suites
too. I use

make -s check-world -j4 PROVE_FLAGS='-j4 --quiet --nocolor --nocount'

on an 8-core machine, and get typical runtimes under 2m30s.

If there were a way to get prove to be absolutely quiet (its --quiet is
a joke unfortunately), I'd lobby for a switch to make pg_regress quiet
too. The amount of useless noise this recipe generates is annoying,
and tends to make it hard to find where the actual error is when
there is one.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-05-20 18:00:27 Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
Previous Message Andres Freund 2019-05-20 16:49:08 Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.