| From: | Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: Logical replication existing data copy |
| Date: | 2017-03-25 04:45:14 |
| Message-ID: | 23540acf-526e-6f49-e94a-88692cc3d92f@catalyst.net.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 25/03/17 07:52, Peter Eisentraut wrote:
> On 3/24/17 10:09, Petr Jelinek wrote:
>> On 24/03/17 15:05, Peter Eisentraut wrote:
>>> On 3/23/17 19:32, Petr Jelinek wrote:
>>>> Yes, I also forgot to check if the table actually exists on subscriber
>>>> when fetching them in CREATE SUBSCRIPTION (we have check during
>>>> replication but not there).
>>> I think for this we can probably just change the missing_ok argument of
>>> RangeVarGetRelid() to false.
>>>
>>> Unless we want the custom error message, in which case we need to change
>>> AlterSubscription_refresh(), because right now it errors out because
>>> missing_ok = false.
>>>
>> You are right, stupid me.
> Committed this version.
>
Minor niggle:
bench=# DROP PUBLICATION pgbench;
DROP STATISTICS <===
I'm guessing that notification is wrong.
regards
Mark
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-25 04:52:17 | Re: Logical replication existing data copy |
| Previous Message | Mithun Cy | 2017-03-25 04:43:00 | Re: [POC] A better way to expand hash indexes. |