Re: BUG #6671: Killed restore command causes postmaster to exit

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: edward(at)heroku(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6671: Killed restore command causes postmaster to exit
Date: 2012-05-31 22:53:17
Message-ID: 23488.1338504797@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

edward(at)heroku(dot)com writes:
> We have this thing where we kill the restore command sometimes, to ensure
> it's not stuck.

Um, what makes you think that's a good idea?

> This has rarely led to postmaster dying afterwards instead of retrying.

"Rarely"? As I read the code, it will happen every single time.
Failure of the restore process is a failure, we do not retry.
(The general theory is that if you think you need retries, you
should code the restore_command to handle that.)

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Adrian Klaver 2012-05-31 23:45:32 Re: BUG #6666: pg_upgrade 9.2beta1 plpython/plpython2
Previous Message Tom Lane 2012-05-31 22:48:01 Re: BUG #6668: hashjoin cost problem